fix: Use node representation for Block #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
changed the title
Block
islamaliev
approved these changes
Jun 20, 2024
| @@ -30,7 +30,7 @@ import ( | |||
| // Schema is the IPLD schema type that represents a `Block`. | |||
| var ( | |||
| Schema schema.Type | |||
| SchemaPrototype schema.TypedPrototype | |||
| SchemaPrototype ipld.NodePrototype | |||
There was a problem hiding this comment.
question: I wonder where this ipld coming from. I don't see any import that ends with "ipld"
There was a problem hiding this comment.
go-ipld-prime is the package 🙂
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#2745 ## Description This PR ensures that the node being passed to the link system is in it's representation form. This will allow the use of optional fields. Node that the 2 added `block` unit tests are there to cover when the optional `isEncrypted` field will be added to `Block` ipld schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2745
Description
This PR ensures that the node being passed to the link system is in it's representation form. This will allow the use of optional fields.
Node that the 2 added
blockunit tests are there to cover when the optionalisEncryptedfield will be added toBlockipld schema.Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: