feat: New cmd for docs auto generation #2096
Conversation
islamaliev
force-pushed
the
feat/islam/cmd-for-auto-doc-gen
branch
from
9c05060 to
ce14a55
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2096 +/- ##
===========================================
+ Coverage 73.93% 74.14% +0.21%
===========================================
Files 248 248
Lines 24710 24710
===========================================
+ Hits 18267 18320 +53
+ Misses 5192 5133 -59
- Partials 1251 1257 +6
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Requesting changes super quick before continuing the review as the todo is a major red flag for me and I don't want this merged if approved by someone else whilst I'm still going through it. Will continue the rest of the review now, as the todo doesn't really change anything else already in the review.
|
I don't think we should have this as part of the main Defra CLI but lets discuss it during standup. |
islamaliev
force-pushed
the
feat/islam/cmd-for-auto-doc-gen
branch
2 times, most recently
from
bf68130 to
20812dc
Compare
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func TestGendocsCmd_IfNoErrors_ReturnGenerationOutput(t *testing.T) { |
There was a problem hiding this comment.
praise: These read really nicely, thanks Islam :)
islamaliev
force-pushed
the
feat/islam/cmd-for-auto-doc-gen
branch
from
20812dc to
fd98484
Compare
## Relevant issue(s) Resolves sourcenetwork#2095 ## Description This change adds a new command for generating documents automatically. It also includes fixes for some overlooked edge cases.
## Relevant issue(s) Resolves sourcenetwork#2095 ## Description This change adds a new command for generating documents automatically. It also includes fixes for some overlooked edge cases.
Relevant issue(s)
Resolves #2095
Description
This change adds a new command for generating documents automatically.
It also includes fixes for some overlooked edge cases.
Tasks
How has this been tested?
Unit tests and manual command execution with a running defradb node.
Specify the platform(s) on which this was tested: