Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Makefile using test flags and timeout #1397

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Apr 23, 2023

Relevant issue(s)

Resolves #1251

Description

Just fixes this little annoying detail I had a few times.

Is 60 seconds per package enough for the slow CI? (I think the timeout is per package)

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Apr 23, 2023
@orpheuslummis orpheuslummis self-assigned this Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #1397 (f6870e6) into develop (a0160e0) will increase coverage by 0.12%.
The diff coverage is n/a.

❗ Current head f6870e6 differs from pull request most recent head 6f0a46c. Consider uploading reports for the commit 6f0a46c to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1397      +/-   ##
===========================================
+ Coverage    70.52%   70.64%   +0.12%     
===========================================
  Files          185      184       -1     
  Lines        17934    17836      -98     
===========================================
- Hits         12648    12601      -47     
+ Misses        4321     4283      -38     
+ Partials       965      952      -13     

see 13 files with indirect coverage changes

Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,6 +25,8 @@ BUILD_FLAGS=-trimpath -ldflags "\
-X 'github.com/sourcenetwork/defradb/version.GitCommitDate=$(VERSION_GITCOMMITDATE)'"
endif

TEST_FLAGS=-race -shuffle=on -timeout 60s
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: 60s might even be too much but since it's in the CI it's not a big deal.

@orpheuslummis orpheuslummis merged commit 75f6da8 into develop Apr 25, 2023
@orpheuslummis orpheuslummis deleted the orpheus/chore/makefile-test-flags branch April 25, 2023 17:55
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite uses overly long default timeout
2 participants