Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestLogWritesMessagesToFeedbackLog missing clearConfig and clearRegistry causing log path error #595

Closed
fredcarle opened this issue Jul 6, 2022 · 0 comments · Fixed by #596
Closed

TestLogWritesMessagesToFeedbackLog missing clearConfig and clearRegistry causing log path error #595

fredcarle opened this issue Jul 6, 2022 · 0 comments · Fixed by #596

Comments

@fredcarle
Copy link
Collaborator

This test function wasn't clearing the config and registry globals causing the config to remain with an output path that was no longer valid.
@fredcarle fredcarle mentioned this issue Jul 6, 2022
Merged
4 tasks
fredcarle added a commit that referenced this issue Jul 6, 2022
@fredcarle
fix: Add config and registry clearing to TestLogWritesMessagesToFeedb…
0f54d22 
…ackLog (#596)

Relevant issue(s)
Resolves #595

Description
This PR fixes an issues where the troubled test function, when running before another test function that specified an empty log path slice, would cause the config global to keep an invalid output path in memory.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Add config and registry clearing to TestLogWritesMessagesToFeedb…
b125177 
…ackLog (sourcenetwork#596)

Relevant issue(s)
Resolves sourcenetwork#595

Description
This PR fixes an issues where the troubled test function, when running before another test function that specified an empty log path slice, would cause the config global to keep an invalid output path in memory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add config and registry clearing to TestLogWritesMessagesToFeedbackLog sourcenetwork/defradb
1 participant
@fredcarle