Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: HTTP API #372

Closed
1 task done
fredcarle opened this issue Apr 21, 2022 · 1 comment · Fixed by #382
Closed
1 task done

Refactor: HTTP API #372

fredcarle opened this issue Apr 21, 2022 · 1 comment · Fixed by #382
Assignees
@fredcarle
Labels
area/api Related to the external API component
Milestone
DefraDB v0.3

Comments

@fredcarle
Copy link
Collaborator

fredcarle commented Apr 21, 2022 •
edited by shahzadlone
Loading

SUB-TASKS
@fredcarle fredcarle self-assigned this Apr 21, 2022
@fredcarle fredcarle added this to the DefraDB v0.3 milestone Apr 21, 2022
@fredcarle fredcarle added the area/api Related to the external API component label Apr 21, 2022
shahzadlone added a commit that referenced this issue Apr 26, 2022
@shahzadlone
fix: Parsing request body on a GET request.
8e93274 
Probably not ideal, however, this is some of the GQL clients send the data in the request body when making a GET request.

Tested this fixed Insomnia, and some other GQL clients.

TODO:
Leaving this as temporary fix to be cleaned / hopefully be moved to a POST request as a sub-task of: #372
@shahzadlone shahzadlone mentioned this issue Apr 26, 2022
Closed
@shahzadlone
Copy link
Member

Added #367 as a subtask. Also referenced the rough branch / commit that fixes #367 (but needs to be cleaned up, it was meant for when we only use GET request).

@fredcarle fredcarle mentioned this issue Apr 27, 2022
Merged
fredcarle added a commit that referenced this issue May 6, 2022
@fredcarle
refactor: Rename NewCidV1_SHA2_256 to mixedCaps (#415)
b094519 
Resolves #372
Resolves #367
fredcarle added a commit that referenced this issue May 12, 2022
@fredcarle
refactor: Improve the HTTP API implementation (#382)
593214a 
Resolves #372
Resolves #367

This PR restructures the api/http package with idiomatic patterns and a few useful utility functions.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
refactor: Rename NewCidV1_SHA2_256 to mixedCaps (sourcenetwork#415)
337cb45 
Resolves sourcenetwork#372
Resolves sourcenetwork#367
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
refactor: Improve the HTTP API implementation (sourcenetwork#382)
e6058e7 
Resolves sourcenetwork#372
Resolves sourcenetwork#367

This PR restructures the api/http package with idiomatic patterns and a few useful utility functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/api Related to the external API component
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging a pull request may close this issue.

refactor: Improve the HTTP API implementation sourcenetwork/defradb
2 participants
@fredcarle @shahzadlone