Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly null GraphQL input values cause panic #3012

Closed
nasdf opened this issue Sep 16, 2024 · 0 comments · Fixed by #3013
Closed

Explicitly null GraphQL input values cause panic #3012

nasdf opened this issue Sep 16, 2024 · 0 comments · Fixed by #3013
Assignees
@nasdf
Labels
area/query Related to the query component bug Something isn't working
Milestone
DefraDB v0.14

Comments

@nasdf
Copy link
Member

nasdf commented Sep 16, 2024

We do not correctly handle explicitly null values in GQL requests.
@nasdf nasdf added bug Something isn't working area/query Related to the query component labels Sep 16, 2024
@nasdf nasdf added this to the DefraDB v0.14 milestone Sep 16, 2024
@nasdf nasdf self-assigned this Sep 16, 2024
@nasdf nasdf mentioned this issue Sep 16, 2024
Merged
4 tasks
@nasdf nasdf closed this as completed in 36eacbe Sep 18, 2024
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this issue Feb 21, 2025
@nasdf
fix: GraphQL null argument parsing (sourcenetwork#3013)
f250e5e 
## Relevant issue(s)

Resolves sourcenetwork#3012

## Description

This PR fixes an issue where explicitly null GQL inputs would cause a
panic.

## Tasks

- [x] I made sure the code is well commented, particularly
hard-to-understand areas.
- [x] I made sure the repository-held documentation is changed
accordingly.
- [x] I made sure the pull request title adheres to the conventional
commit style (the subset used in the project can be found in
[tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)).
- [x] I made sure to discuss its limitations such as threats to
validity, vulnerability to mistake and misuse, robustness to
invalidation of assumptions, resource requirements, ...

## How has this been tested?

Added tests

Specify the platform(s) on which this was tested:
- MacOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nasdf nasdf

Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.14
Development

Successfully merging a pull request may close this issue.

fix: GraphQL null argument parsing nasdf/defradb
1 participant
@nasdf