Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counter CRDT currently don't support encryption #2696

Closed
fredcarle opened this issue Jun 7, 2024 · 0 comments · Fixed by #2698
Closed

Counter CRDT currently don't support encryption #2696

fredcarle opened this issue Jun 7, 2024 · 0 comments · Fixed by #2698
Assignees
@fredcarle
Labels
area/crdt Related to the (Merkle) CRDT system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.12

Comments

@fredcarle
Copy link
Collaborator

fredcarle commented Jun 7, 2024 •
edited
Loading

The counter CRDTs are stored as concrete types (int64 or float64) instead of bytes. This makes them ill prepared for the upcoming document encryption feature.
@fredcarle fredcarle added the refactor This issue specific to or requires *notable* refactoring of existing codebases and components label Jun 7, 2024
@fredcarle fredcarle added this to the DefraDB v0.12 milestone Jun 7, 2024
@fredcarle fredcarle self-assigned this Jun 7, 2024
@fredcarle fredcarle mentioned this issue Jun 7, 2024
Merged
4 tasks
@fredcarle fredcarle added the area/crdt Related to the (Merkle) CRDT system label Jun 7, 2024
fredcarle added a commit that referenced this issue Jun 10, 2024
@fredcarle
refactor: Change counters to support encryption (#2698)
8d0c756 
## Relevant issue(s)

Resolves #2696 

## Description
This PR changes the counter CRDTs to make them support the document
encryption feature. They previously stored their values as concrete
types (int64 and float64) instead of bytes. Storing them as bytes allow
them to be stored plainly or encrypted.
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this issue Feb 21, 2025
@fredcarle
refactor: Change counters to support encryption (sourcenetwork#2698)
d17a664 
## Relevant issue(s)

Resolves sourcenetwork#2696 

## Description
This PR changes the counter CRDTs to make them support the document
encryption feature. They previously stored their values as concrete
types (int64 and float64) instead of bytes. Storing them as bytes allow
them to be stored plainly or encrypted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/crdt Related to the (Merkle) CRDT system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.12
Development

Successfully merging a pull request may close this issue.

refactor: Change counters to support encryption fredcarle/defradb
1 participant
@fredcarle