-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document updates produce incorrect DAG state. #1811
Comments
We actually have a fair few tests for this (e.g. TestQueryCommitsWithFieldNameFieldAndUpdate), it very much appears to be working via We do however have no tests for gql/request updates - this does appear to be broken, and this test gap needs to be closed. |
Will likely fix the bug as part of #1816 |
Lens fetcher does not appear to be responsible. Leading candidate is the fetcher interface simplication. |
## Relevant issue(s) Resolves #1811 ## Description Only updates updated fields via update requests by returning a clean document from Decode.
## Relevant issue(s) Resolves sourcenetwork#1811 ## Description Only updates updated fields via update requests by returning a clean document from Decode.
Describe the problem
DAG nodes from update mutations contain more than just the fields changed, they contain all the fields defined along with the field(s) changed.
To Reproduce
Create a document, update a document, run a commit request for the composite type. Will show a commit with all fields included in the update, when it
Expected behavior
should only include the newest field(s) (delta)
Additional context
Potentially related to the LensFetcher, havent confirmed, works in 0.5.1, broken in 0.6.0
The text was updated successfully, but these errors were encountered: