fix: Dont double up badger file path #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1299 +/- ##
===========================================
- Coverage 70.47% 70.38% -0.09%
===========================================
Files 184 184
Lines 17825 17825
===========================================
- Hits 12562 12546 -16
- Misses 4311 4323 +12
- Partials 952 956 +4
|
tbh there are no tests (manual) from the Windows perspective 😬. Both Shahzad and I who run windows develop soley via WSL. |
|
Tested on an actual windows build (powershell). Looking good! |
|
Cheers John! |
Config magic means that these are not nessecarily the same values, and that checking the wrong one can double up the path value.
AndrewSisley
force-pushed
the
sisley/fix/I1293-server-dump-2
branch
from
3ab939b to
3a527f2
Compare
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Check the path in the config, not the result Config magic means that these are not nessecarily the same values, and that checking the wrong one can double up the path value. * Correctly document config file magic
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Check the path in the config, not the result Config magic means that these are not nessecarily the same values, and that checking the wrong one can double up the path value. * Correctly document config file magic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1293
Description
Previously if $HOME/.defradb is empty, the first time defradb start is run it will create and run defra from the correct folder. If you close down the server and re-run defradb start, it will create and run defra from
$HOME/.defradb/$HOME/.defradb/data, but load the config from the correct location.Might be worth someone giving this one a quick test from windows.
Specify the platform(s) on which this was tested: