fix: Dont double up badger file path (sourcenetwork#1299)

* Check the path in the config, not the result

Config magic means that these are not nessecarily the same values, and that checking the wrong one can double up the path value.

* Correctly document config file magic

config/config.go

@@ -181,7 +181,7 @@ func (cfg *Config) validate() error {
 
 func (cfg *Config) paramsPreprocessing() error {
 	// We prefer using absolute paths.
-	if !filepath.IsAbs(cfg.Datastore.Badger.Path) {
+	if !filepath.IsAbs(cfg.v.GetString("datastore.badger.path")) {
 		cfg.v.Set("datastore.badger.path", filepath.Join(cfg.Rootdir, cfg.v.GetString("datastore.badger.path")))
 	}
 

config/configfile_yaml.gotmpl

@@ -1,6 +1,6 @@
 # DefraDB configuration (YAML)
 
-# NOTE: Paths below are relative to the DefraDB directory.
+# NOTE: Paths below are relative to the DefraDB directory unless otherwise stated.
 # By default, the DefraDB directory is "$HOME/.defradb", but
 # can be changed via the $DEFRA_ROOTDIR env variable or --rootdir CLI flag.
 
@@ -10,6 +10,8 @@ datastore:
       # memory: in-memory version of badger
     store: {{ .Datastore.Store }}
     badger:
+        # The path to the database data file(s), relative paths here will be converted to absolute file paths
+        # on database start.
         path: {{ .Datastore.Badger.Path }}
         # Maximum file size of the value log files. The in-memory file size will be 2*valuelogfilesize.
         # Human friendly units can be used (ex: 500MB).