Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No tests explicitly cover database restart #1082

Closed
AndrewSisley opened this issue Feb 7, 2023 · 0 comments · Fixed by #1504
Closed

No tests explicitly cover database restart #1082

AndrewSisley opened this issue Feb 7, 2023 · 0 comments · Fixed by #1504
Assignees
@AndrewSisley
Labels
area/db-system Related to the core system related components of the DB area/testing Related to any test or testing suite
Milestone
DefraDB v0.5.1

Comments

@AndrewSisley
Copy link
Contributor

No tests explicitly cover database restart - the change detector does cover this implicitly, but only if a breaking change doc has not been provided. I nearly missed a bug recently because of this, and we should add (non-change-detector) tests to cover this.
@AndrewSisley AndrewSisley added area/db-system Related to the core system related components of the DB area/testing Related to any test or testing suite labels Feb 7, 2023
@AndrewSisley AndrewSisley mentioned this issue May 5, 2023
Closed
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone May 5, 2023
@AndrewSisley AndrewSisley self-assigned this May 8, 2023
@AndrewSisley AndrewSisley mentioned this issue May 15, 2023
Merged
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@AndrewSisley @fredcarle
test: Add DB/Node Restart tests (sourcenetwork#1504)
d411c93 
## Relevant issue(s)

Resolves sourcenetwork#1082 

## Description

Adds DB/Node Restart tests. This will be required by Lens (e.g. to make
sure migrations are not lost on restart). IIRC I think this also found
sourcenetwork#1482 (fixed by Fred).

---------

Co-authored-by: Fred Carle <fredcarle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/db-system Related to the core system related components of the DB area/testing Related to any test or testing suite
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

test: Add DB/Node Restart tests AndrewSisley/defradb
1 participant
@AndrewSisley