Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAG sync conflict resolution is not achieving eventual consistency #1029

Closed
fredcarle opened this issue Jan 13, 2023 · 0 comments · Fixed by #1031
Closed

DAG sync conflict resolution is not achieving eventual consistency #1029

fredcarle opened this issue Jan 13, 2023 · 0 comments · Fixed by #1031
Assignees
@fredcarle
Labels
area/crdt Related to the (Merkle) CRDT system bug Something isn't working
Milestone
DefraDB v0.5

Comments

@fredcarle
Copy link
Collaborator

When two node have the same number of independent updates prior to syncing, syncing them will result in the current value on each node to be unchanged due to a priority mismatch on the register.
@fredcarle fredcarle added bug Something isn't working area/crdt Related to the (Merkle) CRDT system labels Jan 13, 2023
@fredcarle fredcarle added this to the DefraDB v0.5 milestone Jan 13, 2023
@fredcarle fredcarle self-assigned this Jan 13, 2023
@fredcarle fredcarle mentioned this issue Jan 13, 2023
Merged
4 tasks
fredcarle added a commit that referenced this issue Jan 17, 2023
@fredcarle
fix: Improve DAG sync with highly concurrent updates (#1031)
210423c 
Relevant issue(s)
Resolves #1029
Resolves #1030

Description
This PR resolves the eventual consistency bug when highly concurrent updates would cause the DAG syncer to fail reaching consistency. It also adds a simple retry mechanic to avoid sync issues when there is a transaction conflict on the head store.
shahzadlone pushed a commit that referenced this issue Apr 13, 2023
@fredcarle @shahzadlone
fix: Improve DAG sync with highly concurrent updates (#1031)
2784800 
Relevant issue(s)
Resolves #1029
Resolves #1030

Description
This PR resolves the eventual consistency bug when highly concurrent updates would cause the DAG syncer to fail reaching consistency. It also adds a simple retry mechanic to avoid sync issues when there is a transaction conflict on the head store.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
fix: Improve DAG sync with highly concurrent updates (sourcenetwork#1031
d9a4419 
)

Relevant issue(s)
Resolves sourcenetwork#1029
Resolves sourcenetwork#1030

Description
This PR resolves the eventual consistency bug when highly concurrent updates would cause the DAG syncer to fail reaching consistency. It also adds a simple retry mechanic to avoid sync issues when there is a transaction conflict on the head store.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
area/crdt Related to the (Merkle) CRDT system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

fix: Improve DAG sync with highly concurrent updates sourcenetwork/defradb
1 participant
@fredcarle