Skip to content

Commit

Permalink
PR FIXUP - Document command-buffer limitation
Browse files Browse the repository at this point in the history
This is a change from the prior solutino, as the (un)subscribe and event channels were separate.
  • Loading branch information
AndrewSisley committed Apr 14, 2023
1 parent b138c07 commit 55b61c7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions events/simple.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ type simpleChannel[T any] struct {
//
// It is important that all stuff gets sent through this single channel to ensure
// that the order of operations is preserved.
//
// WARNING: This does mean that non-event commands can block the database if the buffer
// size is breached (e.g. if many subscribe commands occupy the buffer).
commandChannel chan any
eventBufferSize int
hasClosedChan chan struct{}
Expand Down

0 comments on commit 55b61c7

Please sign in to comment.