Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable noRedeclare to prevent Biome crash #4015

Merged
merged 1 commit into from
May 2, 2024

Conversation

philipp-spiess
Copy link
Contributor

We found that it causes biome to crash causing issues in the VS Code extension (and likely some files won't be linted the way we expected it to because of the crash):

pnpm biome

> @sourcegraph/cody@ biome /Users/philipp/dev/cody
> biome check --apply --error-on-warnings .

Biome encountered an unexpected error

This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fixing the issue:

Source Location: crates/biome_js_semantic/src/semantic_model/scope.rs:115:33
Thread Name: biome::worker_9
Message: no entry found for key

Biome encountered an unexpected error

This is a bug in Biome, not an error in your code, and we would appreciate it if you could report it to https://github.com/biomejs/biome/issues/ along with the following information to help us fixing the issue:

Source Location: crates/biome_js_semantic/src/semantic_model/scope.rs:115:33
Thread Name: biome::worker_4
Message: no entry found for key

./vscode/src/configuration-keys.ts internalError/panic  INTERNAL  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ processing panicked: no entry found for key

  ⚠ This diagnostic was derived from an internal Biome error. Potential bug, please report it if necessary.


./lib/shared/src/models/types.ts internalError/panic  INTERNAL  ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

  ✖ processing panicked: no entry found for key

  ⚠ This diagnostic was derived from an internal Biome error. Potential bug, please report it if necessary.


Checked 739 files in 221ms. No fixes needed.

You can find infos on this crash in biomejs/biome#2659. Disabling noRedeclare fixes this issue.

Test plan

α dev/cody 🐙(ps/biome-disable-no-redeclare)✗
pnpm biome

> @sourcegraph/cody@ biome /Users/philipp/dev/cody
> biome check --apply --error-on-warnings .

Checked 741 files in 195ms. No fixes needed.

@philipp-spiess philipp-spiess requested review from a team and bobheadxi May 2, 2024 09:12
@philipp-spiess philipp-spiess enabled auto-merge (squash) May 2, 2024 09:13
@philipp-spiess philipp-spiess merged commit 9426a94 into main May 2, 2024
17 of 18 checks passed
@philipp-spiess philipp-spiess deleted the ps/biome-disable-no-redeclare branch May 2, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants