MOTM-851: Redirect user to the page they visited before logging in after... #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@ahilles107 can we merge this to 4.4 as well? |
|
I don't like the solution of using referer header. i would prefer to use custom request parameter (post|get) called: I can accept it when you will add this also to socialAction (like we have it done in master branch - https://github.com/sourcefabric/Newscoop/blob/master/newscoop/application/controllers/AuthController.php#L118 ). |
|
sounds good to me....done |
|
sorry, one more change need, please dont merge yet |
|
To make this _target_path field default should I add this to application/forms/Login.php? |
|
ok, I think this is ready |
ahilles107
pushed a commit
that referenced
this pull request
Dec 10, 2014
MOTM-851: Redirect user to the page they visited before logging in after...
takeit
added a commit
to takeit/Newscoop
that referenced
this pull request
Mar 4, 2015
ahilles107
pushed a commit
that referenced
this pull request
Mar 4, 2015
A proper merge of #918 into 4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... they login