-
-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equals bar ( = ) missing top bar | weight 11 down | #140
Comments
CC: @ChrisRM |
@chrissimpkins I just did some testing of bold and italics. It seems like this is an issue with your Both ChrisRM's and My operators were rendered to be bold. Operator Rendering Tests:
|
We've seen some odd issues with the Java renderer in JetBrains editors. Sorry for the troubles and thanks for all of your work to address the problem. I uninstalled Flash so I can't view the video, but my understanding from your description is that when it is rendered as code and there are both regular set and bold/bold-italic elements in the same line of text then you see a missing top stroke in the |
And that this is a text size dependent phenomenon that occurs at some but not at all text sizes? |
Yes, this is text size dependent. I have tested sizes 7, 8, 9, 10, 11, 12, 13, and 14. This issue occurs with size size 11 and below. |
Can you also confirm that it only happens with the |
This occurs when the |
@ciscorucinski got it. Thank you! |
For a visual - #141 (comment) |
I can confirm that I am seeing the top bar in the hinted renders at all sizes between 6 - 20 in the bold and bold italic sets. This does not appear to be a problem with our hinting in the bold or bold italic sets in v2.015 of the Hack typeface. |
@ChrisRM : any thoughts here? |
@chrissimpkins What software did you use to test the possible bold issue? I figured out how to change the font and weight in |
@chrissimpkins I'm sorry, I don't see how this is related to my plugin. Seems like an issue with the jetbrain platform. |
@ChrisRM Thanks Chris. That addressed the question. I did not know if the plugin modified the line spacing in some way that might lead to this problem. We've had numerous issues with the Java renderer in the JetBrains editors. @ciscorucinski I recommend reporting on the JetBrains issue tracker. I used |
@chrissimpkins just to be clear, you have determined that this is not an issue on your side? When I report, I want to be able to clearly stated that fact if I can |
I can verify that I am not seeing an issue in the design, the hinting, or the metrics of our glyph. |
I have submitted the issue. If you want to add extra information, or want to oversee the conversation, then the link is: https://youtrack.jetbrains.com/issue/IDEA-147317 |
@ciscorucinski Thank you! I will keep an eye on it too. |
@ciscorucinski did you happen to submit an issue report on the JDK tracker for this? I had another user who reported the same problem and it seems that JetBrains is pointing the finger at the Java renderer. |
@chrissimpkins I do remember going through the process of submitting the bug report on the JDK. However, I cannot remember if I was actually successful or not. I cannot find the issue at all right now. I would say, submit again. We now have 4 reports on this type of issue - the other bug report, this bug report, and the 2 reports from JetBrains. |
thank you very much! |
I mean, it would be a good idea for someone to submit another bug report to make sure. It has been a while since I looked at this, and I am confused at what categories and subsystems this would fall under based on the JDK submission process right now. Sorry, I have my hands full at the moment. |
I understood and gave you an abbreviated response from my phone :) In discussion with @kolletzki about it outside of the issue report thread. It sounds like he intends to followup on the issue with JetBrains +/- JDK issue trackers. Will see if he learns anything new to update here. |
I did not find any time today, but I will submit a bug report to the JDK issue tracker tomorrow. I'll keep you informed. |
@kolletzki No rush. As you can see this has been open for some time. Please let us know if you discover anything. Happy to work from our end to sort this out. |
All: We are making some progress on these JetBrains editor (Java renderer) + Windows issues in #129. Will update here when/if we have any additional information. |
Also see this resolved (workaround) issue in the JDK tracker: |
Last update. We currently recommend that all Windows users try installs (particularly upgrades) with our new Windows installer. It addresses a number of font caching/duplicate font issues on Windows that have led to rendering problems. Details here: |
@chrissimpkins Recent builds of Android Studio (2.2 preview 2) includes a bundled build of OpenSDK "to address various font rendering and stability issues". I know Android Studio 2.2 preview 1 had some font rendering issues that my previous version (AS 2.0) did not have. I cannot patch to preview 2 (due to a bug in preview 1) and I have to download the huge install to install it on my laptop. When I have a chance to download it, I will see if the issue still persists. Edit: This issue still persists with only plain italic text (for me). However, you might notice a decrease (or maybe increase) in font rendering issues from Android Studio 2.2 preview 2 or higher due to this change. Just a FYI. https://sites.google.com/a/android.com/tools/download/studio/builds/2-2-preview-2 |
@ciscorucinski Thanks Christopher. Pinging @jorgheymans on this issue. He has been working on a Java font renderer testing tool and (I think) we may be ready to kick the tires. Jorg, thoughts? |
@ciscorucinski we are trying to track down this and #129 , seems that the intellij toolsuite is doing "something" under "certain" circumstances that make the font rendering go haywire. We're still investigating this. Could you try and add -Dsun.java2d.font.scaler=t2k to your IDE startup options ? There should be a .vmoptions in your installation directory. Please let us know if this solved your issue. Also, which jdk are you using ? |
@jorgheymans Yes, the But here is the info from the About screen
|
@ciscorucinski @jorgheymans do you know if this information has been submitted to the Java issue tracker? |
What information in particular? The side-effects? I know all the other issues |
Aren't these are Java JDK issues, not JetBrains (or Google in the case of Android Studio) software issues? Wondering if they have been reported directly to the issue trackers for Java so that we can get to the root issue across all of these applications. |
Most of these are JDK issues (my new bold issues with the I would see what @jorgheymans has to say |
👍 |
@ciscorucinski if android studio supports it, can you try running it with an early access release of jdk9 https://jdk9.java.net/download/ |
I tried JDK9. However, that does not fix any issue. I also tried it with and without the 't2k' workaround and the related before and after workaround issues are still present with JDK9 |
hmmm https://youtrack.jetbrains.com/issue/IDEA-145206 says that jetbrains does not support jdk9 as runtime yet so unsure exactly how you tested this. |
You can select JDK9 to be used in your project and restart the IDE; however, you cannot run your project. The font rendering from the JDK appears to work though. |
But the jdk used to compile the project is not the same as the one used by the ide itself. When you go to the about screen what jre version does it say? |
ok, it doesn't change
|
Checking to see if this remains an active issue with recent changes to Hack and any changes on the Java renderer side? Please reopen if so. Thanks |
Environment:
Windows 10
Android Studio 1.5 Preview
Customizations:
Chris Simpkin's Hack Typeface v2.015
ChrisRM's JetBrain Material Theme
ChrisRM's Material Color Scheme
Chris Rucinski's Material Color Scheme (My Color Scheme)
Definitions:
Summary:
Equals bar
(=
) disappears onlywhen using the Hack typeface using a font size 11 or below
ANDwhen using a coloring scheme listed above
.Notes:
Visual:
I am switching between two pictures I have taken of the same text using Hack at size 11.
rendered as a comment
rendered as if it is code
.The
=
will lose the top bar. I have the#
symbol there for reference.The text was updated successfully, but these errors were encountered: