Columns broken in 5.4

[nickhamze]

Something changed and the columns look fine on the backend but not on the frontend. The classes aren't present at all on the frontend.

[Mamaduka]

@nickhamze I can reproduce this issue in WP 5.3.2 as well.

P.S. Can you point me a WP version where columns work, so I can see what changed in core block?

[nickhamze]

@Mamaduka

Weird I'm using it here and the columns work fine:
https://hellofromseattle.com/apps/

But when I try to create a page on the the same site it doesn't work.

I think it means that it broke from 1.0.0 to 1.0.1 as that first list was created with 1.0.0.

Maybe this commit broke it:
65c8fb3

[Mamaduka]

You're right.

The following condition will always be true for core/list block and return props without modifications.

if ( typeof props.className === 'undefined' || ! props.className ) {
	return props;
}

Unfortunately, my solution also triggers block validation error as mentioned in the #1 issue. I'm not able to find anything in Gutenberg repo that might help us solve the block validation issue.

[nickhamze]

@Mamaduka What if we created a column style? Would that let us add classes without triggering validation errors?

[Mamaduka]

@nickhamze core/list block doesn't support generated class names, so I don't think styles will work with it.

Keeping an eye on this issue and hopefully some better option will be part of the core.

Currently, we have to provide this bad experience for the users.

[nickhamze]

@Mamaduka could we add the classes here somehow. We did that with guidepost in the beginning.

[Mamaduka]

@nickhamze pushed the fix, can you test again and also confirm that issue from #1 doesn't happen as well?

[nickhamze]

@Mamaduka yeah works well. I screwed up and did the 1.0.1 manually so the repo still says we're on 1.0.0 don't forget to bump it to 1.0.2 before pushing the new version.

[Mamaduka]

Changes are deployed to WP.org.