Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial bit masks #75

Merged
merged 7 commits into from
Jun 3, 2020
Merged

Partial bit masks #75

merged 7 commits into from
Jun 3, 2020

Conversation

sonelu
Copy link
Owner

@sonelu sonelu commented Jun 3, 2020

Change the terminology: now "bits" used to compare the internal value in register and "mask" used for partial control of the bitwise values.

Fixes #74
Fixes #72

@sonelu sonelu added this to the Release 0.1 milestone Jun 3, 2020
@sonelu sonelu self-assigned this Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #75 into master will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   96.31%   96.79%   +0.48%     
==========================================
  Files          25       25              
  Lines        2305     2310       +5     
  Branches      336      338       +2     
==========================================
+ Hits         2220     2236      +16     
+ Misses         53       46       -7     
+ Partials       32       28       -4     
Impacted Files Coverage Δ
roboglia/base/register.py 100.00% <100.00%> (ø)
roboglia/base/sensor.py 100.00% <100.00%> (ø)
roboglia/dynamixel/sync.py 92.90% <100.00%> (+4.25%) ⬆️
roboglia/dynamixel/bus.py 96.81% <0.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7aa8f7...335705d. Read the comment docs.

@sonelu sonelu merged commit 77d88b4 into master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] BoolRegister with fractional application [BUG] Remove use of reg_name in dynamixel.sync
1 participant