Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoolRegister with mask and RegisterWithConversion with sign #46

Merged
merged 6 commits into from
May 18, 2020

Conversation

sonelu
Copy link
Owner

@sonelu sonelu commented May 18, 2020

Now BoolRegister can have an attached mask and a rule of masking.
RegisterWithConversion can now have a defined sign bit - useful for registers in 2's complement
Registers can now be duplicated and use different external rules by marking them as "clone".

Fixes #34
Fixes #44
Fixes #45

@sonelu sonelu added this to the Release 0.1 milestone May 18, 2020
@sonelu sonelu self-assigned this May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #46 into master will increase coverage by 1.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   92.18%   94.04%   +1.86%     
==========================================
  Files          24       24              
  Lines        1765     1813      +48     
  Branches      231      244      +13     
==========================================
+ Hits         1627     1705      +78     
+ Misses        101       81      -20     
+ Partials       37       27      -10     
Impacted Files Coverage Δ
roboglia/base/device.py 100.00% <100.00%> (+4.00%) ⬆️
roboglia/base/register.py 100.00% <100.00%> (+5.51%) ⬆️
roboglia/dynamixel/bus.py 91.62% <0.00%> (+0.98%) ⬆️
roboglia/base/joint.py 100.00% <0.00%> (+4.65%) ⬆️
roboglia/base/robot.py 100.00% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acb86b9...8fea852. Read the comment docs.

@sonelu sonelu merged commit 0e30b51 into master May 18, 2020
@sonelu sonelu deleted the boolean-with-mask branch May 18, 2020 15:38
@sonelu sonelu restored the boolean-with-mask branch May 18, 2020 15:39
@sonelu sonelu deleted the boolean-with-mask branch May 23, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask for BoolRegister Fix handling of multiple registers for the same address Need a "signed" register
1 participant