Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit is better than implicit #29

Merged
merged 8 commits into from
May 14, 2020
Merged

Explicit is better than implicit #29

merged 8 commits into from
May 14, 2020

Conversation

sonelu
Copy link
Owner

@sonelu sonelu commented May 14, 2020

Completely re-write the constructors for all classes that were using the 'init_dict' approach.
Document all parameters and re-write the comments on most of the classes.

@codecov
Copy link

codecov bot commented May 14, 2020

Codecov Report

Merging #29 into master will increase coverage by 0.80%.
The diff coverage is 87.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   89.43%   90.24%   +0.80%     
==========================================
  Files          23       23              
  Lines        1467     1568     +101     
  Branches      189      213      +24     
==========================================
+ Hits         1312     1415     +103     
+ Misses        117      108       -9     
- Partials       38       45       +7     
Impacted Files Coverage Δ
roboglia/dynamixel/bus.py 84.31% <71.87%> (-2.05%) ⬇️
roboglia/base/robot.py 93.16% <78.72%> (-5.54%) ⬇️
roboglia/base/device.py 92.10% <82.35%> (-7.90%) ⬇️
roboglia/base/bus.py 87.17% <86.36%> (-4.49%) ⬇️
roboglia/dynamixel/sync.py 89.65% <87.50%> (+7.04%) ⬆️
roboglia/dynamixel/register.py 91.66% <88.23%> (-8.34%) ⬇️
roboglia/base/joint.py 95.34% <88.46%> (-4.66%) ⬇️
roboglia/base/register.py 93.33% <91.89%> (-6.67%) ⬇️
roboglia/i2c/bus.py 98.54% <93.33%> (+12.40%) ⬆️
roboglia/utils/checks.py 96.96% <94.44%> (-3.04%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e995719...1a7264c. Read the comment docs.

@sonelu sonelu merged commit 0fbed11 into master May 14, 2020
@sonelu
Copy link
Owner Author

sonelu commented May 16, 2020

Fixes #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant