Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Revert xmldom github reference to standard version string #243

Closed
bhamail opened this issue Aug 6, 2021 · 1 comment
Closed

[BUG] Revert xmldom github reference to standard version string #243

bhamail opened this issue Aug 6, 2021 · 1 comment

Comments

@bhamail
Copy link
Contributor

bhamail commented Aug 6, 2021

To fix a security vulnerability, we needed to update to a version of xmldom that is not yet published on npmjs.com.

After xmldom 0.7.0 is published, we should revert the package.json version to a standard version string, as in remove this github version and replace it with a standard version string (like: '^0.7.0') when xmldom 0.7.0 is published to npmjs.com.

Relates to PR #242

See: xmldom/xmldom#270

cc @bhamail / @DarthHater / @allenhsieh / @Slim-Shary

@bhamail bhamail added the bug label Aug 6, 2021
brent-spiner pushed a commit that referenced this issue Sep 7, 2021
## [4.0.31](v4.0.30...v4.0.31) (2021-09-07)

### Bug Fixes

* Make caching class return undefined if property does not exist ([#247](#247)) ([8e3b3ad](8e3b3ad))
* use newer node version in CI release process, required to run semantic-release. ([589e0ce](589e0ce))
* use newly published @xmldom/xmldom package. fixes [#243](#243) ([9f8b646](9f8b646))
@brent-spiner
Copy link

🎉 This issue has been resolved in version 4.0.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants