This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add shred version filters to Crds Accessors #8027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase on the tip of master to pick up bea9cd9, it contains some extra logging that might help debug why CI failed |
sagar-solana
force-pushed
the
checK_shred_version
branch
from
8e77654 to
dee208a
Compare
Codecov Report
@@ Coverage Diff @@
## master #8027 +/- ##
========================================
- Coverage 82.1% 82% -0.1%
========================================
Files 245 245
Lines 53067 53101 +34
========================================
- Hits 43579 43577 -2
- Misses 9488 9524 +36 |
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Add shred version filters to Crds Accessors * Adopt entrypoint shred_version if one isn't provided (cherry picked from commit 64c42e2)
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Add shred version filters to Crds Accessors * Adopt entrypoint shred_version if one isn't provided (cherry picked from commit 64c42e2)
mvines
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Add shred version filters to Crds Accessors * Adopt entrypoint shred_version if one isn't provided (cherry picked from commit 64c42e2)
mvines
pushed a commit
that referenced
this pull request
Jan 30, 2020
* Add shred version filters to Crds Accessors * Adopt entrypoint shred_version if one isn't provided (cherry picked from commit 64c42e2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Gossiped Shred Versions aren't really used.
Having clusters running with different shred versions simultaneously causes undesired interactions between clusters because of gossip.
Summary of Changes
crds_versionaccessor functions.Turbine, Broadcast, Repair should all be considering nodes running on the same version of the cluster and ignore those on different versions.
all_*variants to some accessor functions so that spy nodes can function correctlyGossip, however, will still continue to work across all shred versions of clusters.