This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Legitimately map transactions to statuses in blocktree #7011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
getConfirmedBlock
RPC returns dummy transaction status data, becauseBlocktree::map_transactions_to_statuses()
isn't hooked up.Summary of Changes
RpcTransactionStatus
in anOption
in order to allowgetConfirmedBlock
to function on validators that have not enabled the TransactionStatus store. (Statuses that cannot be found return None.) When ImplementgetConfirmedBlock
RPC method #6867 item 5 is implemented, it should probably also preventmap_transactions_to_statuses()
from firing at all to save all the db get attempts on an empty column.... Since there are no apis writing data to the TransactionsStatus store,
getConfirmedBlock
returns None for all RpcTransactionStatuses.Toward #6867
This will break
getConfirmedBlock
in https://github.com/solana-labs/solana-web3.js again, again