Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

add a clock to validator windows (part 3 of #309) #448

Merged
merged 1 commit into from
Jun 25, 2018
Merged

add a clock to validator windows (part 3 of #309) #448

merged 1 commit into from
Jun 25, 2018

Conversation

rob-solana
Copy link
Contributor

  • count entries processed by Bank
  • initialize windows with initial height of Entries

@rob-solana
add a clock to validator windows (part 3 of solana-labs#309)
4f377dd 
 * count entries processed by Bank
 * initialize windows with initial height of Entries
garious
garious reviewed Jun 25, 2018
View reviewed changes
Copy link
Contributor

@garious garious left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this could use a test. I'd think that you need to pass entry_count() to the leader's default_window() for the validator to see the same count as the leader.

sakridge
sakridge approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aeyakovenko aeyakovenko merged commit 1919ec2 into solana-labs:master Jun 25, 2018
garious
garious reviewed Jun 25, 2018
View reviewed changes
src/bank.rs
if !entry.transactions.is_empty() {
for result in self.process_transactions(entry.transactions) {
result?;
}
}
self.register_entry_id(&entry.id);
}
Ok(())
Ok(self.entry_count())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rob-solana, It's strange to both return this value and set a state variable. You're offering two ways to get the same information. I'd recommend getting rid of the state variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the return value is a nice info thingie. the state variable is the real useful one: it's pulled out later for server/streamer/window construction

@rob-solana rob-solana added the work in progress This isn't quite right yet label Jun 26, 2018
@rob-solana rob-solana deleted the initialize-windows-with-Entry-count branch June 26, 2018 00:14
mvines added a commit to mvines/solana that referenced this pull request Jun 26, 2018
@mvines
Revert "add a clock to validator windows (part 3 of solana-labs#309) (s…
4efd462 
…olana-labs#448)"

This reverts commit 1919ec2.
mvines added a commit to mvines/solana that referenced this pull request Jun 26, 2018
@mvines
Revert "add a clock to validator windows (part 3 of solana-labs#309) (s…
8a52a1c 
…olana-labs#448)"

This reverts commit 1919ec2.
@rob-solana rob-solana removed the work in progress This isn't quite right yet label Jun 26, 2018
@rob-solana rob-solana restored the initialize-windows-with-Entry-count branch June 26, 2018 20:42
@rob-solana rob-solana deleted the initialize-windows-with-Entry-count branch June 26, 2018 20:56
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
@jackcmay
Remove pack's dependency on TokenError (solana-labs#448)
157936c 
* Remove pack's dependency on TokenError

* nudge
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
@jackcmay
backport solana-labs#448 to v2
51dc1ae
@Kashuhackerone Kashuhackerone mentioned this pull request Jun 20, 2023
Open
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this pull request Jan 10, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
165a874 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this pull request Mar 22, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
eaee34b 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
godmodegalactus pushed a commit to godmodegalactus/solana that referenced this pull request Mar 28, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
78141ac 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this pull request Apr 15, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
e496b5b 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)
godmodegalactus pushed a commit to blockworks-foundation/solana that referenced this pull request May 30, 2024
@buffalu
Backport Jito Patch (solana-labs#408)
fcae767 
Backport clone derivation (416) (solana-labs#418)

backports solana-labs#430: update jito-programs (solana-labs#432)

Backport solana-labs#446 to v1.17 (solana-labs#448)

[JIT-1661] Faster Autosnapshot (solana-labs#445)

v1.17: Backport solana-labs#449 (solana-labs#451)

backports solana-labs#419: add upsert to accountoverrides (solana-labs#421)

backport 428 runtime-plugin (solana-labs#458)

[JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499)

Backport solana-labs#500 to v1.17 (solana-labs#507)

Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Faster MEV tip claiming (v1.17) (solana-labs#568)

Backport Release Fixes (solana-labs#586)

Update release URLs for jito-solana (solana-labs#589)

Backports solana-labs#595: correctly initialize account overrides (solana-labs#599)

Fix: Ensure set contact info to UDP port instead of QUIC (solana-labs#601)

Buffer bundles that exceed processing time and make the allowed processing time longer (solana-labs#609)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@garious garious garious approved these changes

@sakridge sakridge sakridge approved these changes

@aeyakovenko aeyakovenko aeyakovenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rob-solana @garious @sakridge @aeyakovenko