This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Coalesce packets better #4456
Merged
Coalesce packets better #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4456 +/- ##
========================================
+ Coverage 76.7% 78.5% +1.8%
========================================
Files 176 176
Lines 32363 31683 -680
========================================
+ Hits 24823 24874 +51
+ Misses 7540 6809 -731 |
Codecov Report
@@ Coverage Diff @@
## master #4456 +/- ##
========================================
- Coverage 79% 76.5% -2.5%
========================================
Files 176 177 +1
Lines 31245 32311 +1066
========================================
+ Hits 24707 24746 +39
- Misses 6538 7565 +1027 |
pgarg66
approved these changes
May 28, 2019
rob-solana
reviewed
May 29, 2019
| @@ -238,7 +242,7 @@ impl Packets { | |||
| } | |||
| trace!("got {} packets", npkts); | |||
| i += npkts; | |||
| if npkts != NUM_RCVMMSGS || i >= 1024 { | |||
There was a problem hiding this comment.
This check for NUM_RCVMMSGS is important, it's a signal that there's nothing there now. Do you propose we poll for a full millisecond instead?
There was a problem hiding this comment.
Yes, if the buffer is not full (1k limit is not hit). This early exit creates a lot of really small packet buffers which clog up the banking stage. Small batch performance is much worse than larger batches. I think it's better to take the latency hit early in the pipeline to allow them to clear faster later in the pipeline.
sakridge
force-pushed
the
coalesce-packets-better
branch
from
bf8a444 to
08f72d6
Compare
sakridge
force-pushed
the
coalesce-packets-better
branch
from
08f72d6 to
afa188a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
packet receiver creates lots of hardly-used packets buffers. This causes poor banking and forwarding performance because there are too many small batches in the pipeline.
Summary of Changes
Coalesce packets from streamer better.
Fixes #