This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Save RNG for generating random storage sampling offsets #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagar-solana FYI |
|
Cool, looks good. We'll need to integrate with storage stage as well at some point but this should be fine for now. |
Codecov Report
@@ Coverage Diff @@
## master #4450 +/- ##
========================================
+ Coverage 77.5% 79.3% +1.8%
========================================
Files 176 176
Lines 31970 31286 -684
========================================
+ Hits 24789 24824 +35
+ Misses 7181 6462 -719 |
sagar-solana
approved these changes
May 28, 2019
sakridge
reviewed
May 28, 2019
| @@ -457,6 +466,7 @@ impl Replicator { | |||
| self.hash, | |||
| self.slot, | |||
| Signature::new(&self.signature.to_bytes()), | |||
| proof_index, | |||
There was a problem hiding this comment.
It can be used by the new validators to figure out how many random numbers to generate before they can start validating replicator proofs (i.e. catch up to replicator's random number)
There was a problem hiding this comment.
Ok. I see, it could allow for missing transactions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Replicators are supposed to generate new samples of the segment they're storing. Currently they seem to be coming up with the same sampled hash every time.
Summary of Changes
Save RNG so that a new random number is generated.
Fixes #4353