This repository was archived by the owner on Jan 22, 2025. It is now read-only.
check freeze before updating slot_hashes #4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4448 +/- ##
========================================
- Coverage 79.5% 78% -1.6%
========================================
Files 176 176
Lines 31270 31811 +541
========================================
- Hits 24889 24817 -72
- Misses 6381 6994 +613 |
rob-solana
added a commit
to rob-solana/solana
that referenced
this pull request
May 28, 2019
* check freeze before updating slot_hashes * fixup
danpaul000
pushed a commit
that referenced
this pull request
May 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
freeze() updates slot_hashes with each call
Summary of Changes
only update slot_hashes when updating the bank's hash
Fixes #