This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4419 +/- ##
========================================
+ Coverage 72.3% 72.9% +0.6%
========================================
Files 173 173
Lines 33862 33555 -307
========================================
- Hits 24487 24476 -11
+ Misses 9375 9079 -296 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4419 +/- ##
========================================
+ Coverage 72.3% 72.9% +0.6%
========================================
Files 173 173
Lines 33862 33555 -307
========================================
- Hits 24487 24476 -11
+ Misses 9375 9079 -296 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
_id
for all kinds of unique things, including public keys. This lacks precision and can be confusing, especially when multiple kinds of_id
s are used in the same function.Most newer code in the tree has already switched to using
_pubkey
forPubkey
s, this PR applies this standard broadly.Notable exceptions:
program_id
. This was retained for now as program api crates like to exportid()
andcheck_id()
functions, and I didn't want to take on trying to rename all those in this PR. Maybe we can sneak this in towards the end of 0.16