Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

_id => _pubkey variable renaming #4419

Merged
merged 16 commits into from
May 24, 2019
Merged

_id => _pubkey variable renaming #4419

merged 16 commits into from
May 24, 2019

Conversation

mvines
Copy link
Contributor

@mvines mvines commented May 24, 2019

We use _id for all kinds of unique things, including public keys. This lacks precision and can be confusing, especially when multiple kinds of _ids are used in the same function.

Most newer code in the tree has already switched to using _pubkey for Pubkeys, this PR applies this standard broadly.

Notable exceptions: program_id. This was retained for now as program api crates like to export id() and check_id() functions, and I didn't want to take on trying to rename all those in this PR. Maybe we can sneak this in towards the end of 0.16

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #4419 into master will increase coverage by 0.6%.
The diff coverage is 70.4%.

@@           Coverage Diff            @@
##           master   #4419     +/-   ##
========================================
+ Coverage    72.3%   72.9%   +0.6%     
========================================
  Files         173     173             
  Lines       33862   33555    -307     
========================================
- Hits        24487   24476     -11     
+ Misses       9375    9079    -296

1 similar comment
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #4419 into master will increase coverage by 0.6%.
The diff coverage is 70.4%.

@@           Coverage Diff            @@
##           master   #4419     +/-   ##
========================================
+ Coverage    72.3%   72.9%   +0.6%     
========================================
  Files         173     173             
  Lines       33862   33555    -307     
========================================
- Hits        24487   24476     -11     
+ Misses       9375    9079    -296

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant