This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
044cadd
to
f33a3db
Compare
f33a3db
to
0bd2c85
Compare
any corresponding changes needed to the update instructions in |
yeah. I thought to remove all of them in another PR but seems that it's better to get them all happen here! will push them later! |
nice. thanks! |
t-nelson
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35078 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 830 830
Lines 225019 225019
=======================================
+ Hits 183675 183754 +79
+ Misses 41344 41265 -79 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
rust-toolchain.toml
andci/rust-version.sh
to specify version. it should be okay to have a all-in-one ci docker environment.Summary of Changes
solanalabs/ci:rust_${stable_version}_${nightly_version}