This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Reorg Storage program to look more like the others #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm. we have a StorageState already in storage_stage... |
|
Yikes, StorageState with |
|
Sure. We can go with new names for those.. maybe SharedStorageStageState for outer and StorageStageState for what is the Inner one. |
|
But StorageState vs. StorageProgramState is a less precise name. |
Codecov Report
@@ Coverage Diff @@
## master #3448 +/- ##
========================================
- Coverage 79.3% 79.3% -0.1%
========================================
Files 154 156 +2
Lines 24191 24181 -10
========================================
- Hits 19206 19198 -8
+ Misses 4985 4983 -2 |
|
@sakridge, I agree StorageState isn't very precise as soon as its outside the storage program crate. I renamed it to StorageContract. What do you think? Better? Worse? |
|
@garious StorageContract is good. |
sakridge
approved these changes
Mar 24, 2019
Lichtso
added a commit
to Lichtso/solana
that referenced
this pull request
Nov 7, 2024
* Fixes test_load_transaction_accounts_program_account_executable_bypass. * Fixes test_load_transaction_accounts_data_sizes(). * Removes test_load_transaction_accounts_program_account_not_found_but_loaded().
yihau
pushed a commit
to yihau/solana
that referenced
this pull request
Nov 26, 2024
…olana-labs#3520) Fix - SVM account_loader tests (solana-labs#3448) * Fixes test_load_transaction_accounts_program_account_executable_bypass. * Fixes test_load_transaction_accounts_data_sizes(). * Removes test_load_transaction_accounts_program_account_not_found_but_loaded(). (cherry picked from commit 7403549) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Storage program has different file and naming conventions than the others.
Summary of Changes