This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Make sure banking stage is recording with the same bank that it read #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeyakovenko
changed the title
pgarg66
approved these changes
Mar 22, 2019
Codecov Report
@@ Coverage Diff @@
## master #3447 +/- ##
========================================
+ Coverage 79.9% 79.9% +<.1%
========================================
Files 148 148
Lines 23291 23320 +29
========================================
+ Hits 18617 18646 +29
Misses 4674 4674 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #3447 +/- ##
========================================
+ Coverage 79.9% 79.9% +<.1%
========================================
Files 148 148
Lines 23291 23320 +29
========================================
+ Hits 18617 18646 +29
Misses 4674 4674 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Poh recorder could have a new working bank.
Summary of Changes
Make sure banking stage is recording with the same bank that it read with.
Fixes #