Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

dcou: Update qualifier_attr to 0.2.2 #32838

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

ryoqun
Copy link
Contributor

@ryoqun ryoqun commented Aug 15, 2023

needs to #32829 to land first but (EDIT: landed) qualifier_attr needs to be updated. its internal impl improved quite a bit by JohnScience/qualifier_attr#1, which is released under 0.2.x releases.

thus, the crate now needs to be default-features = false to exclusively switch to the newer impl according to https://crates.io/crates/qualifier_attr/0.2.2#note-on-legacy-attributes.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #32838 (98812cc) into master (6bbf514) will decrease coverage by 0.1%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

❗ Current head 98812cc differs from pull request most recent head de7c1fb. Consider uploading reports for the commit de7c1fb to get more accurate results

@@            Coverage Diff            @@
##           master   #32838     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         785      784      -1     
  Lines      212069   211897    -172     
=========================================
- Hits       173954   173794    -160     
+ Misses      38115    38103     -12     

@ryoqun ryoqun force-pushed the bump-qualifier_attr-to-0.2.2 branch from 98812cc to de7c1fb Compare August 15, 2023 12:06
@ryoqun ryoqun marked this pull request as ready for review August 15, 2023 12:08
@ryoqun ryoqun requested a review from brooksprumo August 15, 2023 12:09
@ryoqun ryoqun changed the title Update qualifier_attr to 0.2.2 dcou: Update qualifier_attr to 0.2.2 Aug 15, 2023
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label Aug 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Aug 15, 2023
@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label Aug 15, 2023
@mergify mergify bot merged commit e700dde into solana-labs:master Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants