deprecates Signature::new in favor of Signature::{try_,}from #32481

behzadnouri · 2023-07-13T16:54:22Z

Problem

Signature::new lacks type-safety and may panic.

Summary of Changes

The commit deprecates this interface and instead implements Signature::{try_,}from.

Signature::new lacks type-safety and may panic. The commit deprecates this interface and instead implements Signature::{try_,}from.

codecov · 2023-07-13T17:57:37Z

Codecov Report

Merging #32481 (1729526) into master (09ddbd7) will increase coverage by 0.0%.
The diff coverage is 92.1%.

@@           Coverage Diff           @@
##           master   #32481   +/-   ##
=======================================
  Coverage    82.1%    82.1%           
=======================================
  Files         778      778           
  Lines      210199   210192    -7     
=======================================
+ Hits       172616   172628   +12     
+ Misses      37583    37564   -19

t-nelson

great initiative! this has needed to die for quite some time

sdk/src/signature.rs

banking-bench/src/main.rs

t-nelson

(cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs

…backport of #32481) (#32510) * deprecates Signature::new in favor of Signature::{try_,}from (#32481) (cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs * resolves mergify merge conflicts --------- Co-authored-by: behzad nouri <behzadnouri@gmail.com>

deprecates Signature::new in favor of Signature::{try_,}from

1729526

Signature::new lacks type-safety and may panic. The commit deprecates this interface and instead implements Signature::{try_,}from.

behzadnouri requested review from t-nelson and steviez July 13, 2023 18:29

t-nelson reviewed Jul 13, 2023

View reviewed changes

sdk/src/signature.rs Show resolved Hide resolved

sdk/src/signature.rs Show resolved Hide resolved

banking-bench/src/main.rs Show resolved Hide resolved

behzadnouri requested a review from t-nelson July 14, 2023 16:15

t-nelson approved these changes Jul 14, 2023

View reviewed changes

behzadnouri merged commit cfb0288 into solana-labs:master Jul 14, 2023

behzadnouri deleted the deprecate-signature-new branch July 17, 2023 12:47

behzadnouri added the v1.16 PRs that should be backported to v1.16 label Jul 17, 2023

mergify bot pushed a commit that referenced this pull request Jul 17, 2023

deprecates Signature::new in favor of Signature::{try_,}from (#32481)

d313296

(cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs

mergify bot mentioned this pull request Jul 17, 2023

v1.16: deprecates Signature::new in favor of Signature::{try_,}from (backport of #32481) #32510

Merged

willhickey pushed a commit that referenced this pull request Jul 18, 2023

deprecates Signature::new in favor of Signature::{try_,}from (#32481)

e4c6bf6

(cherry picked from commit cfb0288) # Conflicts: # perf/src/sigverify.rs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deprecates Signature::new in favor of Signature::{try_,}from #32481

deprecates Signature::new in favor of Signature::{try_,}from #32481

behzadnouri commented Jul 13, 2023

codecov bot commented Jul 13, 2023

t-nelson left a comment

t-nelson left a comment

deprecates Signature::new in favor of Signature::{try_,}from #32481

deprecates Signature::new in favor of Signature::{try_,}from #32481

Conversation

behzadnouri commented Jul 13, 2023

Problem

Summary of Changes

codecov bot commented Jul 13, 2023

Codecov Report

t-nelson left a comment

Choose a reason for hiding this comment

t-nelson left a comment

Choose a reason for hiding this comment