This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Remove executors trait and replace with LoadedProgram #30348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
remove-executors
branch
6 times, most recently
from
7344931 to
5c6a85f
Compare
Lichtso
reviewed
Feb 16, 2023
pgarg66
force-pushed
the
remove-executors
branch
from
5098431 to
87f7d95
Compare
Lichtso
reviewed
Feb 16, 2023
Lichtso
approved these changes
Feb 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
executortrait and implementations are being replaced withLoadedProgram. The loader and bank code needs update.Summary of Changes
Updated code to remove the trait, and its implementations. Replaced with
LoadedProgram.Fixes #