This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Prevent Rent-reward recipients from ending up RentPaying #30130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about adding a log or stat for rent credit that result in rent paying account when the feature is not enabled, so that we can gather such info on mnb now? |
CriesofCarrots
force-pushed
the
rent-exempt-in-dist-rent
branch
2 times, most recently
from
898209a to
0e89393
Compare
CriesofCarrots
force-pushed
the
rent-exempt-in-dist-rent
branch
from
0e89393 to
ffadad0
Compare
HaoranYi
approved these changes
Feb 6, 2023
t-nelson
approved these changes
Feb 6, 2023
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
(cherry picked from commit a14473e)
|
@CriesofCarrots thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is still one way accounts can end up newly rent-paying: a validator identity account with a very small or zero balance may receive a sub-rent-exemption rent distribution here:
solana/runtime/src/bank.rs
Line 5035 in 151585e
Summary of Changes
Add feature-gate that, when active, will burn attempted rent distributions that do not meet rent-state transition requirements
Piggy-backs on #16847 (which in retrospect, should have included a test. I wasted some time thinking the
test_distribute_rent_to_validators_overflowwas testing the credit-overflow checked in that PR)