This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Adds symmetric tests for all cases of un-/re-/deployment inside the same transaction #29725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gram_sbf_upgrade_self_via_cpi() into test_program_sbf_invoke_in_same_tx_as_redeployment(). Adds test_program_sbf_invoke_in_same_tx_as_deployment() and test_program_sbf_invoke_in_same_tx_as_undeployment().
mergify bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
…ame transaction (#29725) Unifies test_program_sbf_upgrade_and_invoke_in_same_tx() and test_program_sbf_upgrade_self_via_cpi() into test_program_sbf_invoke_in_same_tx_as_redeployment(). Adds test_program_sbf_invoke_in_same_tx_as_deployment() and test_program_sbf_invoke_in_same_tx_as_undeployment(). (cherry picked from commit c5380d4) # Conflicts: # programs/bpf/tests/programs.rs # runtime/src/loader_utils.rs
Lichtso
added a commit
that referenced
this pull request
Jan 19, 2023
…ame transaction (#29725) Unifies test_program_sbf_upgrade_and_invoke_in_same_tx() and test_program_sbf_upgrade_self_via_cpi() into test_program_sbf_invoke_in_same_tx_as_redeployment(). Adds test_program_sbf_invoke_in_same_tx_as_deployment() and test_program_sbf_invoke_in_same_tx_as_undeployment(). (cherry picked from commit c5380d4)
Lichtso
added a commit
that referenced
this pull request
Jan 19, 2023
…ame transaction (#29725) Unifies test_program_sbf_upgrade_and_invoke_in_same_tx() and test_program_sbf_upgrade_self_via_cpi() into test_program_sbf_invoke_in_same_tx_as_redeployment(). Adds test_program_sbf_invoke_in_same_tx_as_deployment() and test_program_sbf_invoke_in_same_tx_as_undeployment(). (cherry picked from commit c5380d4)
Lichtso
added a commit
that referenced
this pull request
Jan 19, 2023
…ame transaction (#29725) Unifies test_program_sbf_upgrade_and_invoke_in_same_tx() and test_program_sbf_upgrade_self_via_cpi() into test_program_sbf_invoke_in_same_tx_as_redeployment(). Adds test_program_sbf_invoke_in_same_tx_as_deployment() and test_program_sbf_invoke_in_same_tx_as_undeployment(). (cherry picked from commit c5380d4)
Lichtso
added a commit
that referenced
this pull request
Jan 19, 2023
…ame transaction (backport #29725) (#29756) Adds symmetric tests for all cases of un-/re-/deployment inside the same transaction (#29725) Unifies test_program_sbf_upgrade_and_invoke_in_same_tx() and test_program_sbf_upgrade_self_via_cpi() into test_program_sbf_invoke_in_same_tx_as_redeployment(). Adds test_program_sbf_invoke_in_same_tx_as_deployment() and test_program_sbf_invoke_in_same_tx_as_undeployment(). (cherry picked from commit c5380d4) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The state of the madness is currently neither documented nor covered by test cases (except for redeployment). Here is the effect of a top-level program management instruction on subsequent execution instructions:
Summary of Changes
test_program_sbf_upgrade_and_invoke_in_same_tx()andtest_program_sbf_upgrade_self_via_cpi()intotest_program_sbf_invoke_in_same_tx_as_redeployment().test_program_sbf_invoke_in_same_tx_as_deployment()andtest_program_sbf_invoke_in_same_tx_as_undeployment().