Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

experiments different turbine fanouts for propagating shreds #29393

Merged
merged 1 commit into from
Dec 26, 2022

Conversation

behzadnouri
Copy link
Contributor

@behzadnouri behzadnouri commented Dec 23, 2022

Problem

https://discord.com/channels/428295358100013066/1016733708562202674/1055874753736482846

  • Need to understand how different turbine fanouts perform on the actual cluster.
  • Optimize turbine fanout accordingly.

Summary of Changes

  • The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number.
  • The experiment is feature gated with an additional feature to disable the experiment.

Feature Gate Issue: #29394, #29395

@behzadnouri behzadnouri added the feature-gate Pull Request adds or modifies a runtime feature gate label Dec 23, 2022
bw-solana
bw-solana previously approved these changes Dec 23, 2022
Copy link
Contributor

@bw-solana bw-solana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbiseda
jbiseda previously approved these changes Dec 23, 2022
Copy link
Contributor

@jbiseda jbiseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

t-nelson
t-nelson previously approved these changes Dec 23, 2022
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with nits

The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.
@mergify mergify bot dismissed stale reviews from jbiseda, bw-solana, and t-nelson December 23, 2022 22:29

Pull request has been modified.

@behzadnouri behzadnouri merged commit 456d067 into solana-labs:master Dec 26, 2022
@behzadnouri behzadnouri deleted the turbine-fanout-exprs branch December 26, 2022 14:18
mergify bot pushed a commit that referenced this pull request Dec 26, 2022
The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.

(cherry picked from commit 456d067)

# Conflicts:
#	core/src/retransmit_stage.rs
mergify bot added a commit that referenced this pull request Dec 26, 2022
…#29393) (#29420)

* experiments different turbine fanouts for propagating shreds (#29393)

The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.

(cherry picked from commit 456d067)

# Conflicts:
#	core/src/retransmit_stage.rs

* removes mergify merge conflicts

Co-authored-by: behzad nouri <behzadnouri@gmail.com>
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
…labs#29393)

The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
…labs#29393)

The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
…labs#29393)

The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
…labs#29393)

The commit allocates 2% of slots to running experiments with different
turbine fanouts based on the slot number.
The experiment is feature gated with an additional feature to disable
the experiment.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants