This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
experiments different turbine fanouts for propagating shreds #29393
Merged
behzadnouri
merged 1 commit into
solana-labs:master
from
behzadnouri:turbine-fanout-exprs
Dec 26, 2022
Merged
experiments different turbine fanouts for propagating shreds #29393
behzadnouri
merged 1 commit into
solana-labs:master
from
behzadnouri:turbine-fanout-exprs
Dec 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9181d0
to
bc667f6
Compare
This was referenced Dec 23, 2022
bw-solana
reviewed
Dec 23, 2022
bw-solana
reviewed
Dec 23, 2022
bw-solana
previously approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jbiseda
previously approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
t-nelson
previously approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm with nits
The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment.
bc667f6
to
2742930
Compare
Pull request has been modified.
mergify bot
pushed a commit
that referenced
this pull request
Dec 26, 2022
The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment. (cherry picked from commit 456d067) # Conflicts: # core/src/retransmit_stage.rs
mergify bot
added a commit
that referenced
this pull request
Dec 26, 2022
…#29393) (#29420) * experiments different turbine fanouts for propagating shreds (#29393) The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment. (cherry picked from commit 456d067) # Conflicts: # core/src/retransmit_stage.rs * removes mergify merge conflicts Co-authored-by: behzad nouri <behzadnouri@gmail.com>
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
…labs#29393) The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
…labs#29393) The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
…labs#29393) The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Jan 10, 2023
…labs#29393) The commit allocates 2% of slots to running experiments with different turbine fanouts based on the slot number. The experiment is feature gated with an additional feature to disable the experiment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://discord.com/channels/428295358100013066/1016733708562202674/1055874753736482846
Summary of Changes
Feature Gate Issue: #29394, #29395