This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Don't depend on solana_native_loader for IDs in the SDK #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
approved these changes
Feb 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
========================================
- Coverage 76.7% 76.7% -0.1%
========================================
Files 114 114
Lines 18571 18571
========================================
- Hits 14245 14244 -1
- Misses 4326 4327 +1 |
alessandrod
added a commit
to alessandrod/solana
that referenced
this pull request
Aug 21, 2024
localnet is flaky: https://buildkite.com/anza/agave/builds/9606#019165a1-af5f-4bfa-b329-3c0adba9dc46 It seems that nodes start with overlapping ports and then solana-gossip can't find them. Avoid the issue by using larger port ranges...
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Aug 27, 2024
localnet is flaky: https://buildkite.com/anza/agave/builds/9606#019165a1-af5f-4bfa-b329-3c0adba9dc46 It seems that nodes start with overlapping ports and then solana-gossip can't find them. Avoid the issue by using larger port ranges...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Only runtime.rs really depends on solana_native_loader. The rest of the references are just using reexports from the SDK's native_loader.
Summary of Changes
No longer reexport native_loader. Updated references.