This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Rename solana_program_interface to solana_sdk #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
force-pushed
the
ver
branch
2 times, most recently
from
63093e6 to
d952368
Compare
garious
reviewed
Oct 25, 2018
Cargo.toml
Outdated
| noop = { path = "programs/native/noop" } | ||
| bpf_loader = { path = "programs/native/bpf_loader" } | ||
| lua_loader = { path = "programs/native/lua_loader" } | ||
| solana-program-native-noop = { path = "programs/native/noop" } |
There was a problem hiding this comment.
Does 'program' really need to be in there?
There was a problem hiding this comment.
I guess not, I'll remove it
There was a problem hiding this comment.
I'm thinking native could go away too. Why would the choice of interpreter leak into the package name?
Cargo.toml
Outdated
| bpf_loader = { path = "programs/native/bpf_loader" } | ||
| lua_loader = { path = "programs/native/lua_loader" } | ||
| solana-program-native-noop = { path = "programs/native/noop" } | ||
| solana-program-native-bpf_loader = { path = "programs/native/bpf_loader" } |
There was a problem hiding this comment.
The mix of hyphens and underscores is quite ugly. I'd prefer all hyphens, but wouldn't be opposed to all underscores.
There was a problem hiding this comment.
I did that because with solana-program-native-bpf-loader we lose the difference between
programs/native/ and bpf_loader. Don't care?
|
How about now? |
garious
approved these changes
Oct 25, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
) Bumps [@solana/web3.js](https://github.com/solana-labs/solana-web3.js) from 1.2.7 to 1.4.0. - [Release notes](https://github.com/solana-labs/solana-web3.js/releases) - [Changelog](https://github.com/solana-labs/solana-web3.js/blob/master/.releaserc.json) - [Commits](solana-labs/solana-web3.js@v1.2.7...v1.4.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
wen-coding
added a commit
to wen-coding/solana
that referenced
this pull request
Jul 23, 2024
* Make validator::new return ValidatorError. * Try switching to anyhow and thiserror. * Switch to matches! on error matching.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: #1542