Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

feat: Add getConfirmedBlock api #562

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented Nov 16, 2019

Fixes #558

Fixes CI so the next release can go out 😄

CriesofCarrots
CriesofCarrots previously approved these changes Nov 16, 2019
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, thanks for taking this over!
Can you close this (#558) with this pr?
I think we do still want getConfirmedBlockRaw upstream, but your pr definitely takes the pressure off. I like the flexibility that the _populate method gives us.

(Looks like it's just the capitalized "Add" that's making CI sad 🙄 )

@jstarry
Copy link
Contributor Author

jstarry commented Nov 16, 2019

Oh man, thanks for taking this over!
Can you close this (#558) with this pr?

No problem, sorry didn't see that you already had a self-assigned issue for this!

Looks like it's just the capitalized "Add" that's making CI sad 🙄

🙄x 💯

@jstarry jstarry force-pushed the get-confirmed-block branch from d57d2e9 to 05097ec Compare November 16, 2019 17:33
@mergify mergify bot dismissed CriesofCarrots’s stale review November 16, 2019 17:33

Pull request has been modified.

@codecov-io
Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #562 into master will decrease coverage by 1.2%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #562      +/-   ##
==========================================
- Coverage   71.46%   70.25%   -1.21%     
==========================================
  Files          22       22              
  Lines         869      874       +5     
  Branches      119      118       -1     
==========================================
- Hits          621      614       -7     
- Misses        218      230      +12     
  Partials       30       30
Impacted Files Coverage Δ
src/connection.js 60.38% <25%> (-0.75%) ⬇️
src/transaction.js 87.36% <52.17%> (-5.58%) ⬇️
src/budget-program.js 97% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd987a6...05097ec. Read the comment docs.

@jstarry
Copy link
Contributor Author

jstarry commented Nov 16, 2019

Will follow up with some tests for fromRpcResult

@jstarry jstarry merged commit d1f6fb7 into solana-labs:master Nov 16, 2019
@jstarry jstarry deleted the get-confirmed-block branch November 16, 2019 17:52
@mvines
Copy link
Contributor

mvines commented Nov 16, 2019

🎉 This PR is included in version 0.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete getBlocksSince method; fixup getBlock
4 participants