-
Notifications
You must be signed in to change notification settings - Fork 939
Conversation
a277f94
to
d57d2e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh man, thanks for taking this over!
Can you close this (#558) with this pr?
I think we do still want getConfirmedBlockRaw
upstream, but your pr definitely takes the pressure off. I like the flexibility that the _populate
method gives us.
(Looks like it's just the capitalized "Add" that's making CI sad 🙄 )
No problem, sorry didn't see that you already had a self-assigned issue for this!
🙄x 💯 |
d57d2e9
to
05097ec
Compare
Pull request has been modified.
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
- Coverage 71.46% 70.25% -1.21%
==========================================
Files 22 22
Lines 869 874 +5
Branches 119 118 -1
==========================================
- Hits 621 614 -7
- Misses 218 230 +12
Partials 30 30
Continue to review full report at Codecov.
|
Will follow up with some tests for |
🎉 This PR is included in version 0.25.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Fixes #558
Fixes CI so the next release can go out 😄