This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
elf: error out if sbpf_version.enable_elf_vaddr() and config.optimize_rodata=false #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_rodata=false Enabling virtual addresses requires optimize_rodata=true. Otherwise with optimize_rodata=false we allocate a vec where we join all the readonly sections, and if we allowed virtual addresses then we'd potentially have to allocate huge amounts of memory.
Codecov Report
@@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 89.84% 89.93% +0.09%
==========================================
Files 23 23
Lines 10192 10204 +12
==========================================
+ Hits 9157 9177 +20
+ Misses 1035 1027 -8
|
Lichtso
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling virtual addresses requires optimize_rodata=true. Otherwise with optimize_rodata=false we allocate a vec where we join all the readonly sections, and if we allowed virtual addresses then we'd potentially have to allocate huge amounts of memory.