Support multipart streaming bodies in HttpClient based backends #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kamil-Lontkowski
changed the title
Kamil-Lontkowski
force-pushed
the
HttpClient-streaming-multipart-bodies
branch
from
319f8bd to
63a08c6
Compare
Kamil-Lontkowski
force-pushed
the
HttpClient-streaming-multipart-bodies
branch
from
de22804 to
dbb731f
Compare
adamw
reviewed
Feb 27, 2025
core/src/main/scalajvm/sttp/client4/internal/httpclient/BodyToHttpClient.scala
Outdated
Show resolved
Hide resolved
Kamil-Lontkowski
force-pushed
the
HttpClient-streaming-multipart-bodies
branch
from
d0240d9 to
840fd28
Compare
|
For now monix and zio1 backends have disabled streaming. With zio1 problem was with reading file because it produced |
adamw
reviewed
Mar 3, 2025
|
|
||
| def toPublisher(stream: BinaryStream): F[HttpRequest.BodyPublisher] | ||
|
|
||
| override def multipartBodyPublisher( |
There was a problem hiding this comment.
maybe let's just call the method apply? the repetition doesn't give much more additional info
adamw
reviewed
Mar 3, 2025
core/src/main/scalajvm/sttp/client4/internal/httpclient/MultipartBodyBuilder.scala
Outdated
Show resolved
Hide resolved
|
Great, done! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2407