optimization: avoid MonadErrorOps allocations #370
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
MonadErrorOps
implicit class isn't anAnyVal
, which ends up producing object instantiation in certain scenarios where the JIT compiler isn't able to elide the allocation. This is likely not an oversight sinceAnyVal
s can't have by-name parameters, which the class uses.Solution
Use an implicit conversion +
AnyVal
class instead to avoid allocation while still allowing the by-name parameter.Notes
MonadError
implementation.implicit class
desugars to.=> F[A]
to() => F[A]
doesn't require an allocation, both have the same representation at runtime.