Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matching content type range parameters in presence of wildcards #309

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

adamw
Copy link
Member

@adamw adamw commented Oct 17, 2023

Follow-up to #306

cc @kamilkloch - when the range is */* or sth/*, we don't require parameters to match. Otherwise there are problems with boundaries in multiparts (and probably others)

@adamw adamw merged commit a10d590 into master Oct 17, 2023
@mergify mergify bot deleted the fix-matchingct-wildcards branch October 17, 2023 07:50
@kamilkloch
Copy link

Thank you! I missed that one :/ Also, I could not find an RFC for content negotiation with additional parameters,

// `otherParameters` needs to be fully contained within `range.otherParameters` (ignoring case), but only if the main/sub type aren't wildcards

is our sensible guess.

@adamw
Copy link
Member Author

adamw commented Oct 17, 2023

yes we'll see if people report any further problems :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants