Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hiding warnings in Scarb output #1689

Merged
merged 9 commits into from
Feb 7, 2025
Merged

Allow hiding warnings in Scarb output #1689

merged 9 commits into from
Feb 7, 2025

Conversation

DelevoXDG
Copy link
Contributor

@DelevoXDG DelevoXDG commented Oct 25, 2024 •
edited
Loading

Add no-warning verbosity option, available as --no-warning flag or env var setting

Closes #1660

@DelevoXDG DelevoXDG changed the title Allow hiding warnings Allow hiding warnings in Scarb output Oct 25, 2024
@DelevoXDG DelevoXDG marked this pull request as ready for review October 25, 2024 15:22
maciektr
maciektr reviewed Nov 4, 2024
View reviewed changes
@DelevoXDG DelevoXDG force-pushed the zdobnikau/1660-hide-warnings branch from 7afde01 to d82fd9a Compare November 5, 2024 12:39
@DelevoXDG DelevoXDG requested a review from maciektr November 5, 2024 13:04
maciektr
maciektr reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@maciektr maciektr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! 👋
I'd like to get back to this :D

@DelevoXDG DelevoXDG requested a review from a team as a code owner February 4, 2025 14:53
@DelevoXDG DelevoXDG force-pushed the zdobnikau/1660-hide-warnings branch from 613fe8f to 129268f Compare February 4, 2025 14:57
@DelevoXDG DelevoXDG requested a review from maciektr February 4, 2025 14:58
@maciektr maciektr removed the request for review from wawel37 February 5, 2025 12:17
@DelevoXDG DelevoXDG enabled auto-merge February 7, 2025 11:01
@DelevoXDG DelevoXDG added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit f10d2b6 Feb 7, 2025
22 checks passed
@DelevoXDG DelevoXDG deleted the zdobnikau/1660-hide-warnings branch February 7, 2025 14:20
@BrewTestBot BrewTestBot mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to hide warnings but not errors in Scarb output
2 participants
@DelevoXDG @maciektr