Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add component dependencies to metadata #1655

Merged
merged 12 commits into from
Oct 24, 2024
Merged

Add component dependencies to metadata #1655

merged 12 commits into from
Oct 24, 2024

Conversation

piotmag769
Copy link
Contributor

No description provided.

@piotmag769 piotmag769 linked an issue Oct 17, 2024 that may be closed by this pull request
Expose dependencies information in scarb metadata #1653
Closed
@piotmag769 piotmag769 requested a review from mkaput October 17, 2024 17:11
maciektr
maciektr reviewed Oct 18, 2024
View reviewed changes
mkaput
mkaput requested changes Oct 18, 2024
View reviewed changes
mkaput
mkaput approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from scarb-metadata perspective. I haven't reviewed Scarb internals changes.

@piotmag769 piotmag769 requested review from maciektr and mkaput October 21, 2024 22:20
piotmag769
piotmag769 commented Oct 22, 2024
View reviewed changes
@piotmag769 piotmag769 force-pushed the 1653-expose-dependencies-information-in-scarb-metadata branch from 72c8fde to 42c05e0 Compare October 23, 2024 12:17
@piotmag769 piotmag769 changed the base branch from main to remove-test-collector October 23, 2024 15:12
@piotmag769 piotmag769 force-pushed the 1653-expose-dependencies-information-in-scarb-metadata branch from 8c99d5b to 5769066 Compare October 23, 2024 15:13
@piotmag769 piotmag769 force-pushed the 1653-expose-dependencies-information-in-scarb-metadata branch from 5769066 to df626c5 Compare October 23, 2024 15:19
mkaput
mkaput approved these changes Oct 23, 2024
View reviewed changes
Base automatically changed from remove-test-collector to main October 23, 2024 16:55
@piotmag769 piotmag769 force-pushed the 1653-expose-dependencies-information-in-scarb-metadata branch from a2b4b02 to 0a1b109 Compare October 23, 2024 18:47
@piotmag769 piotmag769 force-pushed the 1653-expose-dependencies-information-in-scarb-metadata branch from 0a1b109 to f3ecb06 Compare October 23, 2024 19:26
maciektr
maciektr reviewed Oct 23, 2024
View reviewed changes
wawel37
wawel37 reviewed Oct 24, 2024
View reviewed changes
@piotmag769 piotmag769 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit d3929e1 Oct 24, 2024
22 checks passed
@piotmag769 piotmag769 deleted the 1653-expose-dependencies-information-in-scarb-metadata branch October 24, 2024 22:28
@BrewTestBot BrewTestBot mentioned this pull request Nov 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@maciektr maciektr maciektr approved these changes

@DelevoXDG DelevoXDG Awaiting requested review from DelevoXDG

@wawel37 wawel37 Awaiting requested review from wawel37

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose dependencies information in scarb metadata
4 participants
@piotmag769 @mkaput @wawel37 @maciektr