feat: scarb fmt a subdirectory #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/scarb-fmt
branch
from
ec20f06 to
9a90488
Compare
mkaput
reviewed
Oct 2, 2024
|
Pushed a commit to avoid emitting the file path in emit mode. Behvaior is similar to foundry. However I have an issue: it seems that in emit mode, the output has an extra empty line at the end. I can't find where this originates from? This causes issues when used in combination with other checkers |
I think it's just that |
maciektr
reviewed
Oct 2, 2024
|
Pushed a version that works fine when integrated with Trunk :) |
enitrat
force-pushed
the
feat/scarb-fmt
branch
2 times, most recently
from
42d4b27 to
3441a1f
Compare
enitrat
commented
Oct 3, 2024
mkaput
reviewed
Oct 3, 2024
maciektr
reviewed
Oct 3, 2024
enitrat
force-pushed
the
feat/scarb-fmt
branch
from
f375937 to
dd47515
Compare
maciektr
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows formatting a single file. Useful for integration with external tools.
Closes #1534