Fix svgs being rendered blurry when at high dpi #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The windows svg rendering pass was always rendering the svg to a bitmap the size of the svg at 100% display scale factor, which would then be stretched at higher scale factors. This meant that the svg would be blurry when running in scale factor systems.
With this change the svg will be rendered taking into account the scale factor.
I also removed an invalid color="none" property set, which would cause errors when running against a debug D2D instance. - That property had no effect, as it was an invalid property value. -- Instead we just leave the property unset when there is no color specified.
Test Plan
Before:
After:
Checklist
README.md__tests__folder