Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new "Safe" JSON serialization implementation. #48

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Introduce new "Safe" JSON serialization implementation. #48

merged 1 commit into from
Aug 11, 2023

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Aug 11, 2023 •
edited
Loading

Introduce a "Safe" JSON serialization implementation:

  1. Try to JSON.dump(..., @limit), and if that fails
  2. Walk over the object graph, replacing self-referential objects and mapping all keys/values to safe representations.

(2) is only done if (1) fails, so it should not affect the fast path as much.

Types of Changes

  • New feature.

Contribution

@ioquatix ioquatix merged commit 7721b9d into main Aug 11, 2023
@ioquatix ioquatix deleted the robust-logging branch August 11, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ioquatix