Ignore Content-Length from env.request_headers

[pilaf]

Closes #51

This makes the adapter ignore Content-Length if given in Faraday's env.request_headers, but only if capitalized, since Async::HTTP will set content-length anyway.

I'd like to add tests too, but I wasn't sure how to test what headers end up in the final request without setting up a dummy server to receive them. Any suggestions?

[ioquatix]

This is looking good.

I'd suggest extracting this into length and then assigning to BodyReadWrapper, which should have this:

class BodyReadWrapper
  def initialize(body, length = nil, block_size: 4096)
    @body = body
    @length = length
    @block_size = block_size
  end

  # ...

  def length
    @length # if known
  end

You'll need to move the if headers = env.request_headers first to extract a local variable if possible.

Is headers.key?(...) case sensitive?

Testing is a bit tricky, but maybe we can mock the client. If you can get the code updated, I can help write the tests.

[pilaf]

@ioquatix

Is headers.key?(...) case sensitive?

Yes. I'd change this to check for both Content-Length and content-length if the intent is to use that value for BodyReadWrapper#length, if you agree.

[ioquatix]

It might be easier, for a first pass, to construct headers = ::Protocol::HTTP::Headers[headers] first, and then length = headers.delete("content-length").